fixed: avoid except:

fixed: prestartup_script - remove useless exception handling when fallback resolving comfy_path

comfyui_manager/common/cnr_utils.py

@@ -112,7 +112,7 @@ async def _get_cnr_data(cache_mode=True, dont_wait=True):
         json_obj = await fetch_all()
         manager_util.save_to_cache(uri, json_obj)
         return json_obj['nodes']
-    except:
+    except Exception:
         res = {}
         print("Cannot connect to comfyregistry.")
     finally:
@@ -237,7 +237,7 @@ def generate_cnr_id(fullpath, cnr_id):
         if not os.path.exists(cnr_id_path):
             with open(cnr_id_path, "w") as f:
                 return f.write(cnr_id)
-    except:
+    except Exception:
         print(f"[ComfyUI Manager] unable to create file: {cnr_id_path}")
 
 
@@ -247,7 +247,7 @@ def read_cnr_id(fullpath):
         if os.path.exists(cnr_id_path):
             with open(cnr_id_path) as f:
                 return f.read().strip()
-    except:
+    except Exception:
         pass
 
     return None

comfyui_manager/common/context.py

@@ -14,7 +14,7 @@ if comfy_path is None:
     try:
         comfy_path = os.path.abspath(os.path.dirname(sys.modules['__main__'].__file__))
         os.environ['COMFYUI_PATH'] = comfy_path
-    except:
+    except Exception:
         logging.error("[ComfyUI-Manager] environment variable 'COMFYUI_PATH' is not specified.")
         exit(-1)
 
@@ -95,7 +95,7 @@ def get_current_comfyui_ver():
 
                 project = data.get('project', {})
                 return project.get('version')
-        except:
+        except Exception:
             return None
 
 
@@ -103,7 +103,7 @@ def get_comfyui_tag():
     try:
         with git.Repo(comfy_path) as repo:
             return repo.git.describe('--tags')
-    except:
+    except Exception:
         return None
 
 

comfyui_manager/common/git_helper.py

@@ -156,27 +156,27 @@ def switch_to_default_branch(repo):
         default_branch = repo.git.symbolic_ref(f'refs/remotes/{remote_name}/HEAD').replace(f'refs/remotes/{remote_name}/', '')
         repo.git.checkout(default_branch)
         return True
-    except:
+    except Exception:
         # try checkout master
         # try checkout main if failed
         try:
             repo.git.checkout(repo.heads.master)
             return True
-        except:
+        except Exception:
             try:
                 if remote_name is not None:
                     repo.git.checkout('-b', 'master', f'{remote_name}/master')
                     return True
-            except:
+            except Exception:
                 try:
                     repo.git.checkout(repo.heads.main)
                     return True
-                except:
+                except Exception:
                     try:
                         if remote_name is not None:
                             repo.git.checkout('-b', 'main', f'{remote_name}/main')
                             return True
-                    except:
+                    except Exception:
                         pass
 
     print("[ComfyUI Manager] Failed to switch to the default branch")
@@ -447,7 +447,7 @@ def restore_pip_snapshot(pips, options):
         res = 1
         try:
             res = subprocess.check_call([sys.executable, '-m', 'pip', 'install'] + non_url)
-        except:
+        except Exception:
             pass
 
         # fallback
@@ -456,7 +456,7 @@ def restore_pip_snapshot(pips, options):
                 res = 1
                 try:
                     res = subprocess.check_call([sys.executable, '-m', 'pip', 'install', x])
-                except:
+                except Exception:
                     pass
 
                 if res != 0:
@@ -467,7 +467,7 @@ def restore_pip_snapshot(pips, options):
             res = 1
             try:
                 res = subprocess.check_call([sys.executable, '-m', 'pip', 'install', x])
-            except:
+            except Exception:
                 pass
 
             if res != 0:
@@ -478,7 +478,7 @@ def restore_pip_snapshot(pips, options):
             res = 1
             try:
                 res = subprocess.check_call([sys.executable, '-m', 'pip', 'install', x])
-            except:
+            except Exception:
                 pass
 
             if res != 0:

comfyui_manager/common/manager_util.py

@@ -54,7 +54,7 @@ def make_pip_cmd(cmd):
 # DON'T USE StrictVersion - cannot handle pre_release version
 # try:
 #     from distutils.version import StrictVersion
-# except:
+# except Exception:
 #     print(f"[ComfyUI-Manager]  'distutils' package not found. Activating fallback mode for compatibility.")
 class StrictVersion:
     def __init__(self, version_string):
@@ -527,7 +527,7 @@ def robust_readlines(fullpath):
     try:
         with open(fullpath, "r") as f:
             return f.readlines()
-    except:
+    except Exception:
         encoding = None
         with open(fullpath, "rb") as f:
             raw_data = f.read()