From 3e53d3d2642526565028d60cc2ccf8c8c394441f Mon Sep 17 00:00:00 2001 From: Andy Lee Date: Mon, 28 Jul 2025 14:54:22 -0700 Subject: [PATCH] docs: remove obsolete C++ ABI compatibility warnings - Remove outdated macOS C++ compatibility warnings from README - Simplify CI workflow by removing macOS-specific failure handling - All tests now pass consistently on macOS after ABI fixes --- .github/workflows/build-reusable.yml | 16 +++------------- tests/README.md | 2 -- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/.github/workflows/build-reusable.yml b/.github/workflows/build-reusable.yml index 1db0eec..f5052ec 100644 --- a/.github/workflows/build-reusable.yml +++ b/.github/workflows/build-reusable.yml @@ -217,25 +217,15 @@ jobs: HF_HUB_DISABLE_SYMLINKS: 1 TOKENIZERS_PARALLELISM: false run: | - # Run all tests, continue on macOS failures - if [[ "${{ matrix.os }}" == macos-* ]]; then - pytest tests/ -x || echo "⚠️ Tests failed on macOS, continuing..." - else - pytest tests/ - fi + # Run all tests + pytest tests/ - name: Run sanity checks (optional) run: | # Run distance function tests if available if [ -f test/sanity_checks/test_distance_functions.py ]; then echo "Running distance function sanity checks..." - python test/sanity_checks/test_distance_functions.py || { - if [[ "${{ matrix.os }}" == macos-* ]]; then - echo "⚠️ Distance function test failed on macOS, continuing..." - else - echo "⚠️ Distance function test failed, continuing..." - fi - } + python test/sanity_checks/test_distance_functions.py || echo "⚠️ Distance function test failed, continuing..." fi - name: Upload artifacts diff --git a/tests/README.md b/tests/README.md index b3cd70b..06274fd 100644 --- a/tests/README.md +++ b/tests/README.md @@ -84,6 +84,4 @@ The `pytest.ini` file configures: ### Known Issues -- On macOS, tests may fail due to C++ standard library compatibility issues -- Tests marked with `@pytest.mark.xfail` are expected to fail on macOS - OpenAI tests are automatically skipped if no API key is provided