fix: Resolve linting issues in MCP integration

- Replace deprecated typing.Dict/List with built-in dict/list
- Fix boolean comparisons (== True/False) to direct checks
- Remove unused variables in demo script
- Update type annotations to use modern Python syntax

All pre-commit hooks should now pass.
This commit is contained in:
aakash
2025-10-06 02:23:55 -07:00
parent 1fdc9dfbfa
commit 98cdcf600b
7 changed files with 25 additions and 27 deletions

View File

@@ -26,7 +26,7 @@ def test_slack_reader_initialization():
# Test basic initialization
reader = SlackMCPReader("slack-mcp-server")
assert reader.mcp_server_command == "slack-mcp-server"
assert reader.concatenate_conversations == True
assert reader.concatenate_conversations
assert reader.max_messages_per_conversation == 100
# Test with custom parameters
@@ -37,7 +37,7 @@ def test_slack_reader_initialization():
max_messages_per_conversation=50
)
assert reader.workspace_name == "test-workspace"
assert reader.concatenate_conversations == False
assert not reader.concatenate_conversations
assert reader.max_messages_per_conversation == 50
print("✅ SlackMCPReader initialization tests passed")
@@ -50,8 +50,8 @@ def test_twitter_reader_initialization():
# Test basic initialization
reader = TwitterMCPReader("twitter-mcp-server")
assert reader.mcp_server_command == "twitter-mcp-server"
assert reader.include_tweet_content == True
assert reader.include_metadata == True
assert reader.include_tweet_content
assert reader.include_metadata
assert reader.max_bookmarks == 1000
# Test with custom parameters
@@ -63,8 +63,8 @@ def test_twitter_reader_initialization():
max_bookmarks=500
)
assert reader.username == "testuser"
assert reader.include_tweet_content == False
assert reader.include_metadata == False
assert not reader.include_tweet_content
assert not reader.include_metadata
assert reader.max_bookmarks == 500
print("✅ TwitterMCPReader initialization tests passed")

View File

@@ -23,7 +23,7 @@ def test_slack_reader_basic():
reader = SlackMCPReader("slack-mcp-server")
assert reader.mcp_server_command == "slack-mcp-server"
assert reader.concatenate_conversations == True
assert reader.concatenate_conversations
# Test message formatting
message = {
@@ -61,7 +61,7 @@ def test_twitter_reader_basic():
reader = TwitterMCPReader("twitter-mcp-server")
assert reader.mcp_server_command == "twitter-mcp-server"
assert reader.include_tweet_content == True
assert reader.include_tweet_content
assert reader.max_bookmarks == 1000
# Test bookmark formatting